MT Search vs. XHTML Snafu

For those of you using the search functionality in MT 2.51 and are trying to make your pages XHTML 1.0/1.1 compliant, consider this a heads up.
MT::App::Search.pm kindly sets the check boxes and select boxes for us before it returns the results. Unfortunately, it sets them using HTML. :-(
That means the search output checkboxes will have the checked attribute set and the select lists will have selected set. These of course are not XHTML compliant and this is in the core modules and cannot be fixed in the search templates them selves.

Here is a patch to remove that functionality from MT::App:Search.pm. I have opted to emove the function entirely as this should really funciton like the comments form does, where this stuff is set via javascript. If you would like a patch the change checked to checked="checked" and selected to selected="selected" let me know and I’ll put on up.

<hr /> Search.pm.orig Thu Jan 16 21:56:19 2003 <p><ins>+</ins> Search.pm Thu Jan 16 21:58:20 2003<br /> <code>@ -276,6 +276,11 @</code></p> sub _set_form_elements { my($app, $tmpl) = @_; <p>+<br /> + ## Skip this stuff. It created potentiall <br /> + ## non-compliant html. Usejavascript instead.<br /> +<br /> + return $tmpl;<br /> +</p> <ol> <li>Fill in user-defined template with proper form settings.<br /> if ($app→{searchparam}{Type} eq ‘newcomments’) {<br /> if ($app→{searchparam}{CommentSearchCutoff}) {<br />